Closed alancai98 closed 2 months ago
Base (legacy) | eval | +/- | |
---|---|---|---|
% Passing | 92.51% | 90.67% | -1.84% |
:white_check_mark: Passing | 5382 | 5276 | -106 |
:x: Failing | 436 | 543 | 107 |
:large_orange_diamond: Ignored | 0 | 0 | 0 |
Total Tests | 5818 | 5819 | 1 |
Number passing in both: 5071
Number failing in both: 231
Number passing in legacy engine but fail in eval engine: 312
Number failing in legacy engine but pass in eval engine: 205 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 205 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
Base (801091c9c4372dfe6d21ecf7be60e3eee36229c4) | 95688259c163250d1d751810a9a3f01f0627bd9b | +/- | |
---|---|---|---|
% Passing | 92.51% | 92.51% | 0.00% |
:white_check_mark: Passing | 5382 | 5382 | 0 |
:x: Failing | 436 | 436 | 0 |
:large_orange_diamond: Ignored | 0 | 0 | 0 |
Total Tests | 5818 | 5818 | 0 |
Number passing in both: 5382
Number failing in both: 436
Number passing in Base (801091c9c4372dfe6d21ecf7be60e3eee36229c4) but now fail: 0
Number failing in Base (801091c9c4372dfe6d21ecf7be60e3eee36229c4) but now pass: 0
Base (801091c9c4372dfe6d21ecf7be60e3eee36229c4) | 95688259c163250d1d751810a9a3f01f0627bd9b | +/- | |
---|---|---|---|
% Passing | 90.67% | 90.67% | 0.00% |
:white_check_mark: Passing | 5276 | 5276 | 0 |
:x: Failing | 543 | 543 | 0 |
:large_orange_diamond: Ignored | 0 | 0 | 0 |
Total Tests | 5819 | 5819 | 0 |
Number passing in both: 5276
Number failing in both: 543
Number passing in Base (801091c9c4372dfe6d21ecf7be60e3eee36229c4) but now fail: 1
Number failing in Base (801091c9c4372dfe6d21ecf7be60e3eee36229c4) but now pass: 1 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang:. The following test(s) were previously passing but now fail:
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Description
I added the binary compatibility checks in #1427 but had not pulled in the latest changes from the
v1
branch (which included some public API changes), so the result of theapiCheck
step after I merged #1427 tov1
branch failed.This PR fixes those errors by running the following:
Other Information
Updated Unreleased Section in CHANGELOG: [NO]
Any backward-incompatible changes? [YES]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.