partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
538 stars 60 forks source link

Initializes Datum and adds functionality to evaluator #1451

Closed johnedquinn closed 3 months ago

johnedquinn commented 5 months ago

Relevant Issues

Description

Internal Notes

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v1@607c4c0). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1 #1451 +/- ## ===================================== Coverage ? 72.30% Complexity ? 2539 ===================================== Files ? 283 Lines ? 20282 Branches ? 3700 ===================================== Hits ? 14664 Misses ? 4596 Partials ? 1022 ``` | [Flag](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1451/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | Coverage Δ | | |---|---|---| | [CLI](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `13.71% <ø> (?)` | | | [EXAMPLES](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `80.07% <ø> (?)` | | | [LANG](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `77.69% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johnedquinn commented 3 months ago

Only change is to fix the test/partiql-tests submodule otherwise ship it.

I believe there is a bug in GitHub's rendering of the submodule diff. For some reason, the commit is the same on v1 as on johnedquinn:v1-eval-value-rebased. Checked the files being "changed" and they're all already in v1. I pushed twice to move to some older submodule commit and then back to what is currently on v1, but it's still not rendering appropriately.