partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
536 stars 60 forks source link

V1 ddl extended keyword #1455

Closed yliuuuu closed 1 month ago

yliuuuu commented 2 months ago

Relevant Issues

Description

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.52% 90.70% -1.82%
:white_check_mark: Passing 5383 5278 -105
:x: Failing 435 541 106
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5819 1

Number passing in both: 5071

Number failing in both: 228

Number passing in legacy engine but fail in eval engine: 313

Number failing in legacy engine but pass in eval engine: 207 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 207 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (28edbb7c92879594c898131f91f4d63598fdb179) 4958cb16a5a613915706f8a5153b7d7b4243b574 +/-
% Passing 92.51% 92.52% 0.02%
:white_check_mark: Passing 5382 5383 1
:x: Failing 436 435 -1
:large_orange_diamond: Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5382

Number failing in both: 435

Number passing in Base (28edbb7c92879594c898131f91f4d63598fdb179) but now fail: 0

Number failing in Base (28edbb7c92879594c898131f91f4d63598fdb179) but now pass: 1 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (28edbb7c92879594c898131f91f4d63598fdb179) 4958cb16a5a613915706f8a5153b7d7b4243b574 +/-
% Passing 90.70% 90.70% 0.00%
:white_check_mark: Passing 5278 5278 0
:x: Failing 541 541 0
:large_orange_diamond: Ignored 0 0 0
Total Tests 5819 5819 0

Number passing in both: 5278

Number failing in both: 541

Number passing in Base (28edbb7c92879594c898131f91f4d63598fdb179) but now fail: 1

Number failing in Base (28edbb7c92879594c898131f91f4d63598fdb179) but now pass: 1 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang:. The following test(s) were previously passing but now fail:

Click here to see - Example 6 — Value Coercion, compileOption: LEGACY

The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - Example 6 — Value Coercion, compileOption: LEGACY
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (v1@28edbb7). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1 #1455 +/- ## ===================================== Coverage ? 72.11% Complexity ? 2499 ===================================== Files ? 264 Lines ? 19802 Branches ? 3681 ===================================== Hits ? 14281 Misses ? 4510 Partials ? 1011 ``` | [Flag](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1455/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | Coverage Δ | | |---|---|---| | [CLI](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `13.71% <ø> (?)` | | | [LANG](https://app.codecov.io/gh/partiql/partiql-lang-kotlin/pull/1455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql) | `77.70% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=partiql#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.