search

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
538 stars 60 forks source link

[DRAFT] Initializes PartiQL-system interfaces and document. #1480

Closed RCHowell closed 3 months ago

RCHowell commented 3 months ago

Description

https://github.com/partiql/partiql-lang-kotlin/blob/v1-path/partiql-planner/README.adoc

This PR initializes the interfaces for the 1.0 planner interfaces which model the PartiQL-system. This review is meant to collect feedback on the high-level public interfaces and documentation before updating internals.

Details can be found in the README.adoc.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 3 months ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.62% 15.68% -76.94%
:white_check_mark: Passing 5422 918 -4504
:x: Failing 432 4936 4504
:large_orange_diamond: Ignored 0 0 0
Total Tests 5854 5854 0

Number passing in both: 881

Number failing in both: 395

Number passing in legacy engine but fail in eval engine: 4541

Number failing in legacy engine but pass in eval engine: 37 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 37 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (4dd09721d56cacf19f4b7e312ac927f247a20975) a0103d6cb91d1d9a6e6a5bc67d90aad5b326a3e4 +/-
% Passing 92.60% 92.62% 0.02%
:white_check_mark: Passing 5421 5422 1
:x: Failing 433 432 -1
:large_orange_diamond: Ignored 0 0 0
Total Tests 5854 5854 0

Number passing in both: 5421

Number failing in both: 432

Number passing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now fail: 0

Number failing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now pass: 1 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (4dd09721d56cacf19f4b7e312ac927f247a20975) a0103d6cb91d1d9a6e6a5bc67d90aad5b326a3e4 +/-
% Passing 87.05% 15.68% -71.37%
:white_check_mark: Passing 5097 918 -4179
:x: Failing 758 4936 4178
:large_orange_diamond: Ignored 0 0 0
Total Tests 5855 5854 -1

Number passing in both: 918

Number failing in both: 758

Number passing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now fail: 4179

Number failing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now pass: 0 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.