search

partiql / partiql-lang-kotlin

PartiQL libraries and tools in Kotlin.
https://partiql.org/
Apache License 2.0
536 stars 60 forks source link

Generates a partiql prelude for PLK #1490

Open RCHowell opened 1 week ago

RCHowell commented 1 week ago

Relevant Issues

https://github.com/orgs/partiql/discussions/64

Description

This commit writes the current function signatures and variants to Ion files (like substrait extensions) so that PartiQL function signatures can be expressed independently of implementations. I am using these for my PR which moves functions out of SPI and into planner/eval respectively.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 1 week ago

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.59% 87.05% -5.53%
:white_check_mark: Passing 5420 5097 -323
:x: Failing 434 758 324
:large_orange_diamond: Ignored 0 0 0
Total Tests 5854 5855 1

Number passing in both: 4894

Number failing in both: 231

Number passing in legacy engine but fail in eval engine: 527

Number failing in legacy engine but pass in eval engine: 203 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang: The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. 203 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (4dd09721d56cacf19f4b7e312ac927f247a20975) 3852092ae2e1d89a4e3cb161040f40247386e86a +/-
% Passing 92.59% 92.59% 0.00%
:white_check_mark: Passing 5420 5420 0
:x: Failing 434 434 0
:large_orange_diamond: Ignored 0 0 0
Total Tests 5854 5854 0

Number passing in both: 5420

Number failing in both: 434

Number passing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now fail: 0

Number failing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (4dd09721d56cacf19f4b7e312ac927f247a20975) 3852092ae2e1d89a4e3cb161040f40247386e86a +/-
% Passing 87.05% 87.05% 0.00%
:white_check_mark: Passing 5097 5097 0
:x: Failing 758 758 0
:large_orange_diamond: Ignored 0 0 0
Total Tests 5855 5855 0

Number passing in both: 5097

Number failing in both: 758

Number passing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now fail: 1

Number failing in Base (4dd09721d56cacf19f4b7e312ac927f247a20975) but now pass: 1 :interrobang: CONFORMANCE REPORT REGRESSION DETECTED :interrobang:. The following test(s) were previously passing but now fail:

Click here to see - Example 6 — Value Coercion, compileOption: LEGACY

The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see - Example 6 — Value Coercion, compileOption: LEGACY