search

partiql / partiql-tests

Test data for checking conformance to the PartiQL specification.
Apache License 2.0
7 stars 1 forks source link

Ports `text_replace` tests to `partiql-tests` and adds null/missing/mistyped argument tests #81

Closed alancai98 closed 1 year ago

alancai98 commented 1 year ago

Closes #78.

Ports the text_replace tests to partiql-tests. Also adds null/missing propagation tests and mistyped argument tests.

These tests are ported under the "extended" directory because the name isn't part of any SQL spec I could find. It appears most other SQL databases (e.g. postgresql, mysql, sqlite, oracle) use the name REPLACE.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vgapeyev commented 1 year ago

These tests are ported under the "extended" directory because the name isn't part of any SQL spec I could find. It appears most other SQL databases (e.g. postgresql, mysql, sqlite, oracle) use the name REPLACE.

The extended directory sounds right to me, since this function was mimicking Postres' non-standard replace. The same name could not be used because REPLACE keyword is already used in PartiQL DML. (But there is nothing special about the text_replace choice itself.)

alancai98 commented 1 year ago

The extended directory sounds right to me, since this function was mimicking Postres' non-standard replace. The same name could not be used because REPLACE keyword is already used in PartiQL DML. (But there is nothing special about the text_replace choice itself.)

I see. Thanks for the context. I'll keep it in the "extended" directory then.