partkeepr / PartKeepr

Open Source Inventory Management
http://www.partkeepr.org
GNU General Public License v3.0
1.36k stars 395 forks source link

Sorting parts in a project #636

Open Aleksei13jul opened 8 years ago

Aleksei13jul commented 8 years ago

Hi Felicitus,

does not work.

To reproduce: demo.partkeepr.org, Edit - Projects, choose a project, try to sort parts (click on Parts column).

FYI, sorting by Quantity works.

Have a nice day.

Drachenkaetzchen commented 8 years ago

I can reproduce the issue.

However, the fix doesn't seem to be trivial. The ExtJS docs say that a sorter can be passed to the column config, which isn't the case (it silently gets ignored). A custom sorter is required to sort by the part's name.

Drachenkaetzchen commented 7 years ago

I just spent an hour figuring out how to implement this. The main problem is that ExtJS sorter functions only work on direct object properties and not on subproperties.

It has to be figured out how to implement this, either by proxying the data into the master object or by magic methods.

Due to the effort required this is re-scheduled to 1.3.

baradhili commented 4 years ago

@Drachenkaetzchen just wondering if this was done in 1.3?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions.

christianlupus commented 4 years ago

To reduce the stress here, I will remove the label and make this issue non-stale.