search

partkeepr / PartKeepr

Open Source Inventory Management
http://www.partkeepr.org
GNU General Public License v3.0
1.37k stars 398 forks source link

Barcode scanner configuration problem #944

Open ladismrkolj opened 6 years ago

ladismrkolj commented 6 years ago

System Information

How to reproduce

On the "Barcode Scanner Configuration" I tried to configure action, but after clicking update, is shows no action selected, and it doesn't work. This also doesn't work on demo. This is how I tried to configure barcode scanner (correct me if I am wrong):

  1. Added modifier and hotkey
  2. click ADD
  3. enter Code and select action
  4. click Update Fill in any steps to reproduce the issue. A good description of an issue would be:
Drachenkaetzchen commented 6 years ago

Works fine for me, maybe try another browser. From the screenshots it looks like you're using IE or Edge, which I both dont have

Drachenkaetzchen commented 6 years ago

Oh nevermind - I was able to reproduce the issue. Yes, it seems to be a display bug - when you edit the row the action is shown.

ladismrkolj commented 6 years ago

Thanks, I got it working now, maybe add it to bugs list.

Drachenkaetzchen commented 6 years ago

yes, just leave the issue open and I'll eventually fix it

ladismrkolj commented 6 years ago

Also I am getting simillar issue as #924, but the temporary fix in that post hasn't fixed mine. Also his error response has "line 0, col 83:" mine has "line 0, col 57:" or something like that, everything else works fine.

KHuffman35 commented 6 years ago

Does the modifier and key need to be embedded in an actual barcode? If I assign " s " as my modifier to perform a part search, can I press this key sequence on my keyboard and follow that key sequence with a barcode scan of the number I'm searching for (assuming I complete these steps within the timeout value set)?

Gasman2014 commented 6 years ago

Most barcode scanners are simple keyboard 'wedges' so enter characters as if directly typed - so I guess typing the modifier on the keyboard and then scanning would work. However it is convenient to at least have the option of a modifier embedded in the barcode. It does allow for simpler one handed operation or operation without a keyboard.

ghost-from-the-past commented 3 years ago

The information is correctly stored in the table SystemPreference and everything is fully functional. Seems to me that at BarcodeScannerConfiguration,js the render function renderer: function (v) { if (v instanceof Ext.data.Model) { return v.get("name"); } else { return i18n("No action selected"); } }, could not retrieve the information back

ghost-from-the-past commented 3 years ago

the fix appears in my pull request https://github.com/partkeepr/PartKeepr/pull/1201