search

partofthething / ace

Python package for performing the Alternating Conditional Expectation (ACE) regression
MIT License
68 stars 20 forks source link

ACE not giving proper numbers #1

Closed partofthething closed 10 years ago

partofthething commented 10 years ago

The ACE algorithm is running and converging, but it doesn't converge to the right answer. What is the issue?

There's a good potential that I'm not applying the expected conditionals correctly. Right now I'm just using the supersmoother S(y|x) as a direct replacement for E(y|x). The FORTRAN code is too unreadable to see how it's supposed to be done.

partofthething commented 10 years ago

It's working now, thanks to the ordering changes in b58b784b9f5d557ccc8f1f6b7a42370f3b9190f9. The results aren't quite as smooth as I want but maybe we can just tweak the supersmoother params. The general shapes are being extracted. Excellent.