search

parttio / textfieldformatter

TextField Formatter Vaadin add-on
Apache License 2.0
13 stars 9 forks source link

Vaadin 22 compatibility #52

Closed Tonne-TM closed 2 years ago

Tonne-TM commented 2 years ago

As Vaadin 22 introduced a lot of changes on how a textfield is composed the add-on does not seem to be working correctly anymore. https://vaadin.com/docs/latest/ds/upgrading/#changes-in-vaadin-22

When you insert numbers they are not automatically formatted anymore. It just looks like a normal textfield. However loading seems to be working fine. The number is rendered correctly.

Example: Left -> loaded, Right -> typed in image

syampillai commented 2 years ago

Yes, not working with Vaadin 22

juuso-vaadin commented 2 years ago

Experienced the same issue when testing with V23 pre-release. My error is: Uncaught TypeError: Cannot read properties of null (reading 'length') (webpack-internal:///../node_modules/cleave.js/dist/cleave-esm.js:1074:26)

johanneshayry commented 2 years ago

V22 should be fixed in 5.4.0

Tonne-TM commented 2 years ago

@johanneshayry Thanks for fixing (and maintaining) this awesome Vaadin extension. Already deployed the new version. Working like intended again.