search

parttio / tinymce-for-flow

TinyMCE wrapper for Vaadin 10+
Other
8 stars 6 forks source link

onDetach JS error when setVisible(false) #33

Closed marekmatus closed 4 weeks ago

marekmatus commented 1 month ago

First of all thanks for the addon :-)

After upgrade to vaadin 24:

When TinyMCE is added to a page but setVisible(false) then after onDetach a javascript error occurs: 

The error has occurred in the JS code: '$0, tinymce.get($0).remove(); '
Uncaught TypeError: tinymce.get(...) is null

Vaadin: 24.3.8 tinymce-for-flow: 4.2.2

mstahv commented 4 weeks ago

Fixed! @TatuLund You had some other fixes in queue or shall we cut a release?

TatuLund commented 3 weeks ago

I pushed my updates today, the master is upto date.

mstahv commented 3 weeks ago

A version with this fix in was already cut on friday.