search

parttio / touchkit

TouchKit is a library of mobile components for Vaadin Framework
https://vaadin.com/directory/component/touchkit
Other
8 stars 11 forks source link

touchkit should have source and javadoc maven attachments #12

Closed steinarb closed 6 years ago

steinarb commented 6 years ago

Touchkit should have source and javadoc maven attachments.

IDEs like eclipse and IntelliJ IDEA will use the source attachments to provide source for maven dependencies when debugging.

The IDEs will also use javadoc attachments to provide tooltips and online documentation for classes and methods from maven depedencies.

steinarb commented 6 years ago

Turns out javadoc and sources are created when the release profile is active: https://github.com/parttio/touchkit/blob/master/touchkit/pom.xml#L37

(I don't see why source and javadoc only have to be built during release, but that's not important)

steinarb commented 6 years ago

Maven complains that the maven-javadoc-plugin configuration lacks a plugin version number:

[WARNING] Some problems were encountered while building the effective model for org.vaadin.touchkit:touchkit:jar:5.0.1-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-javadoc-plugin is missing. @ line 52, column 29
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.