partyrobotics / bartendro

GNU General Public License v2.0
170 stars 89 forks source link

Drink errors when using liquid sensors #93

Closed pmich closed 10 years ago

pmich commented 10 years ago

There's a bug where an error shows up when trying to make a drink that has run out of booze. A drink is allowed to be selected, and after pressing pour, the bot says "Bartendro can't make a drink right now." The drink shouldn't be displayed on the menu in the first place if it can't be made.

pmich commented 10 years ago

Drink selection error: Bartendro can't make this drink right now. Sorry!

No liquids are low or out...

Opening I2C bus to router Done. Discovering dispensers port 0: 43 43 43 -- Found dispenser with pump id 43, index 1 port 1: 4F 4F 4F -- Found dispenser with pump id 4F, index 2 port 2: 23 23 23 -- Found dispenser with pump id 23, index 3 port 3: 19 19 19 -- Found dispenser with pump id 19, index 4 port 4: E2 E2 E2 -- Found dispenser with pump id E2, index 5 port 5: 56 56 56 -- Found dispenser with pump id 56, index 6 port 6: E4 E4 E4 -- Found dispenser with pump id E4, index 7 port 7: 4D 4D 4D -- Found dispenser with pump id 4D, index 8 port 8: AC AC AC -- Found dispenser with pump id AC, index 9 port 9: 5E 5E 5E -- Found dispenser with pump id 5E, index 10 port 10: 15 15 15 -- Found dispenser with pump id 15, index 11 port 11: ED ED ED -- Found dispenser with pump id ED, index 12 port 12: 4A 4A 4A -- Found dispenser with pump id 4A, index 13 port 13: A4 A4 A4 -- Found dispenser with pump id A4, index 14 port 14: 42 42 42 -- Found dispenser with pump id 42, index 15 Opening /dev/ttyAMA0 Done.

Opening I2C bus to router Done. Discovering dispensers port 0: 43 43 43 -- Found dispenser with pump id 43, index 1 port 1: 4F 4F 4F -- Found dispenser with pump id 4F, index 2 port 2: 23 23 23 -- Found dispenser with pump id 23, index 3 port 3: 19 19 19 -- Found dispenser with pump id 19, index 4 port 4: E2 E2 E2 -- Found dispenser with pump id E2, index 5 port 5: 56 56 56 -- Found dispenser with pump id 56, index 6 port 6: E4 E4 E4 -- Found dispenser with pump id E4, index 7 port 7: 4D 4D 4D -- Found dispenser with pump id 4D, index 8 port 8: AC AC AC -- Found dispenser with pump id AC, index 9 port 9: 5E 5E 5E -- Found dispenser with pump id 5E, index 10 port 10: 15 15 15 -- Found dispenser with pump id 15, index 11 port 11: ED ED ED -- Found dispenser with pump id ED, index 12 port 12: 4A 4A 4A -- Found dispenser with pump id 4A, index 13 port 13: A4 A4 A4 -- Found dispenser with pump id A4, index 14 port 14: 42 42 42 -- Found dispenser with pump id 42, index 15 mixer.check_liquid_levels: check levels dispenser 0 level: 56 dispenser 1 level: 60 dispenser 2 level: 68 dispenser 3 level: 61 dispenser 4 level: 63 dispenser 5 level: 67 dispenser 6 level: 66 dispenser 7 level: 70 dispenser 8 level: 64 dispenser 9 level: 62 dispenser 10 level: 65 dispenser 11 level: 69 dispenser 12 level: 57 dispenser 13 level: 53 dispenser 14 level: 65 Checking levels done. New state: 3 mixer.check_liquid_levels: check levels dispenser 0 level: 243 dispenser 1 level: 131 dispenser 2 level: 138 dispenser 3 level: 255 dispenser 4 level: 235 dispenser 5 level: 272 dispenser 6 level: 244 dispenser 7 level: 125 dispenser 8 level: 246 dispenser 9 level: 101 dispenser 10 level: 244 dispenser 11 level: 71 dispenser 12 level: 57 dispenser 13 level: 197 dispenser 14 level: 212 Checking levels done. New state: 3 mixer.check_liquid_levels: check levels dispenser 0 level: 248 dispenser 1 level: 124 dispenser 2 level: 132 dispenser 3 level: 227 dispenser 4 level: 199 dispenser 5 level: 272 dispenser 6 level: 221 dispenser 7 level: 89 dispenser 8 level: 235 dispenser 9 level: 62 dispenser 10 level: 260 dispenser 11 level: 231 dispenser 12 level: 132 dispenser 13 level: 205 dispenser 14 level: 214 Checking levels done. New state: 3 mixer.check_liquid_levels: check levels dispenser 0 level: 247 dispenser 1 level: 121 dispenser 2 level: 132 dispenser 3 level: 225 dispenser 4 level: 200 dispenser 5 level: 266 dispenser 6 level: 166 dispenser 7 level: 145 dispenser 8 level: 193 dispenser 9 level: 171 dispenser 10 level: 259 dispenser 11 level: 172 dispenser 12 level: 131 dispenser 13 level: 204 dispenser 14 level: 211 Checking levels done. New state: 1 mixer.check_liquid_levels: check levels dispenser 0 level: 246 dispenser 1 level: 120 dispenser 2 level: 132 dispenser 3 level: 227 dispenser 4 level: 199 dispenser 5 level: 264 dispenser 6 level: 164 dispenser 7 level: 146 dispenser 8 level: 194 dispenser 9 level: 168 dispenser 10 level: 259 dispenser 11 level: 173 dispenser 12 level: 129 dispenser 13 level: 204 dispenser 14 level: 212 Checking levels done. New state: 2 mixer.check_liquid_levels: check levels dispenser 0 level: 245 dispenser 1 level: 121 dispenser 2 level: 132 dispenser 3 level: 225 dispenser 4 level: 199 dispenser 5 level: 266 dispenser 6 level: 164 dispenser 7 level: 146 dispenser 8 level: 192 dispenser 9 level: 171 dispenser 10 level: 259 dispenser 11 level: 172 dispenser 12 level: 129 dispenser 13 level: 204 dispenser 14 level: 212 Checking levels done. New state: 1 mixer.check_liquid_levels: check levels dispenser 0 level: 247 dispenser 1 level: 121 dispenser 2 level: 131 dispenser 3 level: 225 dispenser 4 level: 199 dispenser 5 level: 264 dispenser 6 level: 164 dispenser 7 level: 146 dispenser 8 level: 193 dispenser 9 level: 169 dispenser 10 level: 259 dispenser 11 level: 173 dispenser 12 level: 130 dispenser 13 level: 204 dispenser 14 level: 211 Checking levels done. New state: 1 Post make drink. State is: 1 Made cocktail: Beach Bum 4 Pineapple Juice (27) 80 ml 9 Rum, Dark (5) 40 ml 120 ml dispensed. done. mixer.check_liquid_levels: check levels dispenser 0 level: 247 dispenser 1 level: 120 dispenser 2 level: 131 dispenser 3 level: 227 dispenser 4 level: 199 dispenser 5 level: 264 dispenser 6 level: 164 dispenser 7 level: 145 dispenser 8 level: 190 dispenser 9 level: 169 dispenser 10 level: 259 dispenser 11 level: 172 dispenser 12 level: 129 dispenser 13 level: 204 dispenser 14 level: 211 Checking levels done. New state: 2 Cannot make drink: Dispenser 2 is out of booze. mixer.check_liquid_levels: check levels dispenser 0 level: 247 dispenser 1 level: 118 dispenser 2 level: 131 dispenser 3 level: 225 dispenser 4 level: 200 dispenser 5 level: 266 dispenser 6 level: 164 dispenser 7 level: 144 dispenser 8 level: 189 dispenser 9 level: 168 dispenser 10 level: 259 dispenser 11 level: 172 dispenser 12 level: 128 dispenser 13 level: 204 dispenser 14 level: 211 Checking levels done. New state: 2 Cannot make drink: Dispenser 2 is out of booze. mixer.check_liquid_levels: check levels dispenser 0 level: 246 dispenser 1 level: 120 dispenser 2 level: 132 dispenser 3 level: 225 dispenser 4 level: 199 dispenser 5 level: 266 dispenser 6 level: 164 dispenser 7 level: 146 dispenser 8 level: 189 dispenser 9 level: 169 dispenser 10 level: 258 dispenser 11 level: 172 dispenser 12 level: 128 dispenser 13 level: 204 dispenser 14 level: 211 Checking levels done. New state: 2

mayhem commented 10 years ago

This bug was the reason I re-wrote the mixer twice. I'm hoping that this bug is now gone!