parzh / iso4217

ISO-4217 as a JSON – https://www.iso.org/iso-4217-currency-codes.html
https://npmjs.org/package/@iso4217/json
MIT License
6 stars 1 forks source link

Postinstall script fails #13

Open askoufis opened 1 year ago

askoufis commented 1 year ago

The postinstall script fails. This bug is present in v20230101.1.9 and potentially v20230101.1.8 (haven't tested this version).

Reproduction

  1. mkdir foo
  2. npm init (just to get a package.json)
  3. yarn add @iso4217/json
  4. Error:
    
    error /code/foo/node_modules/@iso4217/json: Command failed.
    Exit code: 1
    Command: node --unhandled-rejections=strict postinstall.js
    Arguments:
    Directory: /code/foo/node_modules/@iso4217/json
    Output:
    node:internal/modules/cjs/loader:1031
    throw err;
    ^

Error: Cannot find module 'xml2json' Require stack:

parzhitsky commented 1 year ago

Hey! Thanks for the issue! I'll get back to it in about 10 hours, if that's ok.

askoufis commented 1 year ago

Thanks for the quick response. Not an urgent issue for me, take your time 🙂

parzhitsky commented 1 year ago

@askoufis FYI, it looks like this isn't going to be easy to debug. And also the package architecture is cumbersome (what was I thinking 1,5 years ago?!), which doesn't help. I don't have nearly enough motivation to do hard work after working hours :)

So, at the moment, the temporary solution is to use version 20230101.1.6 (the latest that's not affected by the bug). This version is now set to be latest, and versions 1.8 and 1.9 are now deprecated.

Apologies for any inconveniences!

If you have spare time and motivation to dig into it, I'd be very grateful. The bug may or may not be related to: