search

pasa / asdl-rs

Apache License 2.0
10 stars 1 forks source link

Reduce nom dependencies #5

Closed matklad closed 5 years ago

matklad commented 5 years ago

nom pulls in quite a few of the deps. I wonder if we can prune some of those by disabling default nom features? Additionally, given that ASDL syntax is tiny, perhaps it makes sense to just hand-roll a recursive descent parser manually?

pasa commented 5 years ago

I've made a commit with code structure change. I removed lexical feature from nom. For now it depend only from memchr and version_check. I think it's quite small dependency set. About hand written parser. I'd prefer not to do this without a certain need. It will be third implementation :-)

matklad commented 5 years ago

SGTM!