RSS Plugin chokes on invalid torrents from feeds

[GoogleCodeExporter]

Obligatory Bug template (more thorough description found below):

_What steps will reproduce the problem?_
1. Add feed that has invalid torrent files (eg: ShowRSS Californication Feed 
<http://showrss.karmorra.info/feeds/8.rss>)
2. Set up, via RSS manager, some rules that will include some invalid torrents
3. Watch as it does fine until it hits an invalid torrent, then chokes

_What is the expected output? What do you see instead?_
I expect invalid torrents to be ignored, possibly with a log entry that the 
torrent wasn't loaded for whatever reason. However, the torrent isn't ignored, 
rather the whole thing chokes up

_What environment are you using?_
1. My ruTorrent version is: *SVN Rev: 1454*
2. My rTorrent version is: *0.8.6*
3. I use *Apache* version *1454* on *Arch Linux*
3. I use *Firefox 3.6.10* on *Arch Linux*

_Are some errors present in the web-server log?_
No.

_Are some errors present in the browser error console?_
"The request to rtorrent has timed out" when loading the invalid torrents for 
the first time. Sometimes is spits out a bunch of "Error Loading Torrents" 
every few minutes...

_Please provide any additional information below._

I've run into a problem that seems to happen when an RSS feed has an invalid 
torrent file. It seems to run fine until it hits a torrent that is invalid.

The ShowRSS Californication feed is an excellent example (it has a few 'invalid 
torrents', and the new season shouldn't start until January, giving this bug 
report a bit of room to demonstrate on a non-moving feed). The feed can be 
found here:
http://showrss.karmorra.info/feeds/8.rss

For this example, I will only look at the standard def torrents (ones WITHOUT 
_HD 720p:_ in them). If you look down the list, you will see that the first two 
entries, S02E12 and S03E11 are associated with a valid .torrent file from zoink 
(looks like: 
http://torrent.zoink.it/Californication.S03E12.HDTV.XviD-SYS.%5Beztv%5D.torrent)
. However, the third entry, S03E10, is associated with an invalid torrent file 
that links to <http://re.zoink.it/4b1375ec>, which redirects to the main page. 

Loading the feed into the RSS Plugin, I set these rules:
Filter: /Californication S03E.*/i
Exclude: /HD 720p:/i
RSS: Cali Feed
Label: Cali Test
"Don't start the download automatically" is *checked*

The RSS plugin then proceeds to start loading the entries that match my rules 
(12 matches total) one by one. It adds the first two just fine, but once it 
reaches the third entry (the one that ISN'T a .torrent file), it seems to choke 
up and displays "The request to rtorrent has timed out" in the browser log. 
After that, sometimes it starts printing out "Error Loading Torrent <url>" at 
what seem to be regular intervals. 

Another good example is the Dexter feed 
<http://showrss.karmorra.info/feeds/24.rss>. If I only wanted to download the 
HD version (the ones that include HD 720p: in them) I would be able to 
successfully download the first three(S05E01, S04E12, and S04E11). The fourth 
one (S04E10) links to an invalid torrent, and causes the plugin to choke up. 
Please note that a new season has started, and this feed will probably change 
in time.

I expect it to work like this: if it finds an invalid torrent (say, the main 
page to zoink), it should just ignore it, print out a warning in the browser 
log, and continue adding the torrents that are valid.

Original issue reported on code.google.com by ryan.xga...@gmail.com on 4 Oct 2010 at 3:57

[GoogleCodeExporter]

Fixed in r1455.
Thanx for detailed errors description.

Original comment by novik65 on 4 Oct 2010 at 10:22

• Changed state: Fixed

[GoogleCodeExporter]

Oh no, thank you! I loved the response time! =D

Original comment by ryan.xga...@gmail.com on 4 Oct 2010 at 7:03