search

pascalgn / automerge-action

GitHub action to automatically merge pull requests that are ready
MIT License
854 stars 207 forks source link

question on MERGE_REQUIRED_APPROVALS #197

Open SamYuan1990 opened 2 years ago

SamYuan1990 commented 2 years ago

Hi team,

May I know for MERGE_REQUIRED_APPROVALS, will this count for maintainers? or it will count all accounts?

Thanks and regards Sam

pascalgn commented 2 years ago

I think it will count all accounts. I might be wrong, but I think in the past it wasn't possible to give "approval" reviews in repositories where one doesn't have write access to. But anyways, now it looks like it's possible, so the MERGE_REQUIRED_APPROVALS should only count reviews of people who have write access...

SamYuan1990 commented 2 years ago

I think it will count all accounts. I might be wrong, but I think in the past it wasn't possible to give "approval" reviews in repositories where one doesn't have write access to. But anyways, now it looks like it's possible, so the MERGE_REQUIRED_APPROVALS should only count reviews of people who have write access...

ok, so once this one been fixed, we may able to have a try via https://github.com/sustainable-computing-io/kepler/issues/249