Do not treat regular commits as failure

pascalgn / npm-publish-action

GitHub action to automatically publish packages to npm

MIT License

221 stars 29 forks source link

Do not treat regular commits as failure #10

Closed zhouzi closed 4 years ago

zhouzi commented 4 years ago

With this PR, regular commits are no more treated as a failure.

Fix #9

zhouzi commented 4 years ago

Turns out GitHub dropped support for neutral exit codes 🙁 I realize this PR's changes are not ideal, feel free to ignore/close.

pascalgn commented 4 years ago

No, that's fine, I made similar changes to another action! Thanks for the PR! Could you possibly remove the line // process.exitCode = 78;, because I don't like commented code? Otherwise it looks good! 👍

zhouzi commented 4 years ago

@pascalgn Sure, I just pushed the changes 👍

pascalgn commented 4 years ago

Thanks for the PR, it's merged now! 👍