search

pascalgn / npm-publish-action

GitHub action to automatically publish packages to npm
MIT License
221 stars 29 forks source link

[clone] Support for private packages #12 #24

Closed gameolive-studio closed 3 years ago

gameolive-studio commented 3 years ago

Unfortunately the fix is not working

Referring to https://github.com/pascalgn/npm-publish-action/issues/12#issuecomment-650740650

I believe you can just add the following to your package.json:

  "publishConfig": {
    "access": "public"
  },

I am still getting image

stekyne commented 3 years ago

I'm also having issues publishing a private package for an org.

stekyne commented 3 years ago

After some investigating, yarn doesn't even support this command so no surprise. https://github.com/yarnpkg/yarn/issues/5310

Maybe should use NPM for publishing.

pascalgn commented 3 years ago

Yes, looks like the solution in #12 won't work. I think another suggestion was to support configurable arguments for yarn publish. Do you maybe want to try it and create a PR?

gameolive-studio commented 3 years ago

a quick question to understand, At https://github.com/pascalgn/npm-publish-action/blob/master/index.js#L127 why we are doing yarn publish may be it makes sense to use npm publish instead

I have forked the repo and want to try it out https://github.com/gameolive-studio/npm-publish-action

but not don't know hot what to put in my workflow of uses: ref: https://github.com/gameolive-studio/gamelauncher-js/blob/master/.github/workflows/npm-publish.yml#L18

pascalgn commented 3 years ago

You can now use the new PUBLISH_ARGS option, like this:

      with:
        publish_args: "--access private"

Does this help?