search

pascalgrimaud / generator-jhipster-ci

DEPRECATED: now directly to the main generator
Apache License 2.0
16 stars 8 forks source link

Change gitlab ci image/config #14

Closed atomfrede closed 8 years ago

atomfrede commented 8 years ago

Gitlab not supports caching of artifacts, so I don't think we need the heavyweight image by @moifort anymore, as it is hard to maintain. You can make maven and gradle download there dependencies to a the correct location such that they are automatically cached by gitlab ci and cache node modules in addition. So all dependencies are downloaded once (the first run) only.

So @moifort @pascalgrimaud whats your oppinion on this? My image can be found here: https://github.com/atomfrede/gitlab-ci-jhipster-stack

pascalgrimaud commented 8 years ago

LGTM ! I need to find time to work and update this module. PR is welcome too!

atomfrede commented 8 years ago

Maybe I was wrong, at least for the public shared runners provided by gitlab. Downloaded artifacts are cached:

Creating cache maven-test/master...
WARNING: node_modules: no matching files           
src/main/webapp/bower_components: found 2674 matching files 
cache: found 4398 matching files

But each build downloads dependencies again. Using a specific runner works fine, don't know how it is supposed to work with their public runners.

atomfrede commented 8 years ago

@pascalgrimaud Good news! Using public, shared runners now works with caches, so we only need an image with java and node installed, will update the config soon.

pascalgrimaud commented 8 years ago

Nice ! So it's a very simple image

atomfrede commented 8 years ago

Exactly: https://github.com/atomfrede/gitlab-ci-jhipster-stack/blob/master/Dockerfile

pascalgrimaud commented 8 years ago

I tested your last PR and everything is OK for me. Thanks so much I'm closing this and will release soon