Closed hpretl closed 8 months ago
thank you for contributing. To accept third party contribution I require a signed contributor license agreement to ensure we can continue to use OpenVAF in commercial settings aswell. Please download and sign CLA and send it to pascalkuthe@pm.me.
@pascalkuthe I have no issue with signing the CLA, but I need to do this on behalf of my university, which means a full round of legal reviews. For the changes under discussion, this is overkill. I propose we cancel the PR, and you just adapt the 3 tiny locations yourself. Agree?
sure that sounds good to me, thank you!
I was going to fix this myselfy originially but you were faster with your PR
I am currently finishing up the noise integration into OpenVAF which requires very larg changes.
I hope to wrap that up in the next couple of days I will push the fixes once I am done with that to avoid too much juggling of conflicting changesets
Excellent, looking forward to having noise in the sims 😀👍
We have tested the proposed changes on
x86_64
andaarch64
, they work for both; we suggest merging them into the source.This is the Dockerfile that has been used for testing: