search

pascalla / clan-chat-webhook

BSD 2-Clause "Simplified" License
4 stars 2 forks source link

Announcement detection is a bit off #3

Open jammy-dodgers opened 1 year ago

jammy-dodgers commented 1 year ago

image image

image image

image image For this last one - quest messages in general may not work? Though there's not many of us with quests ready to complete to check. That's probably a serverside thing though EDIT: Clannie submitted a seperate report for that, see: https://github.com/pascalla/clanchat.net/issues/4 image

pascalla commented 1 year ago

i've opened a PR which should fix all these issues, will only process and parse messages that are of CLAN_MESSAGE type, which (hopefully) contains all the drop/pb/logs notifications.

From sitting around in my clan chat ive seen the majority of them are, so lets hope they are consistent.

You are right about quests, fixing on plugin side, which might take a bit longer to get in.

https://github.com/runelite/plugin-hub/pull/4411/