search

pascallouisperez / jsonmarshaller

JsonMarshaller is a Java 1.5 library that allows marshalling and unmarshalling of JSON objects to and from entities ("Java classes").
Apache License 2.0
1 stars 0 forks source link

Outdate ASM dependencies #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What about updating ASM dependencies as long as issue 2 is not fixed?

Original issue reported on code.google.com by mguille...@yahoo.fr on 27 Apr 2010 at 4:15

GoogleCodeExporter commented 9 years ago 
oops, title should be "update", not "outdate"

Original comment by mguille...@yahoo.fr on 27 Apr 2010 at 4:16

GoogleCodeExporter commented 9 years ago 
You are welcome to submit a patch to jarjar to shadow the library but no plans 
to
upgrade.

Original comment by pascallo...@gmail.com on 27 Apr 2010 at 5:01

GoogleCodeExporter commented 9 years ago 
Does it mean that you wouldn't apply a patch upgrading dependencies to latest
versions of required jars?

Original comment by mguille...@yahoo.fr on 28 Apr 2010 at 12:37

GoogleCodeExporter commented 9 years ago 
Correct.

Original comment by pascallo...@gmail.com on 28 Apr 2010 at 6:43

GoogleCodeExporter commented 9 years ago 
May I ask why?
Don't you fear to afraid potential users of jsonmarshaller when they see 
dependencies
on outdated libraries that may lead to incompatibilities due to other libraries
depending on recent versions of ASM?

Original comment by mguille...@yahoo.fr on 29 Apr 2010 at 7:37

GoogleCodeExporter commented 9 years ago 
As I feared the dependency on the old version of ASM causes me troubles.

The upgrade is quite simple. In DescriptorFactory#119 just change
      reader.accept(visitor, true);
to
      reader.accept(visitor, ClassReader.SKIP_DEBUG);

and jsonmarshaller works fine with ASM-3.2 (all tests are passing).

Original comment by mguille...@yahoo.fr on 29 Apr 2010 at 3:01

GoogleCodeExporter commented 9 years ago 
Ok buddy. Sure, the upgrade is trivial but in the same way it breaks your 
code...
upgrading would break others code.

Since your a motivated whining user (hehe) I've jarjared the asm into the json 
jar
thus removing the dependency on ASM (at least for clients).

So download http://jsonmarshaller.googlecode.com/files/json-0.20.jar and buy me 
a beer

Original comment by pascallo...@gmail.com on 30 Apr 2010 at 4:08

GoogleCodeExporter commented 9 years ago 
Thanks for jarjaring ASM into json jar. It will become quite expensive to use
jsonmarshaller if I have to buy you a beer each time I have to remember you 
that we
live in 2010 and not in 2006 anymore ;-)

When will the library be the most useful? When it uses totally outdated jars or 
when
it uses the latest version of its dependencies?

Original comment by mguille...@yahoo.fr on 30 Apr 2010 at 10:35