search

pascalvanderheiden / ais-apim-openai

Unleash the power of Azure OpenAI to your application developers in a secure & manageable way with Azure API Management and Azure Developer CLI.
MIT License
33 stars 9 forks source link

TenantId should not be hardcoded in ChargebackProxy #20

Closed iMicknl closed 9 months ago

iMicknl commented 9 months ago

https://github.com/pascalvanderheiden/ais-apim-openai/blob/3ab47b790b96343e261efdb8ed17ff38242ef091/src/Azure.OpenAI.ChargebackProxy/EventHub.cs#L19

Is this required? If so; we should make this optional + set it via the config.

azureholic commented 9 months ago

TenantId is needed for token validation and is a key in the App Configuration Service

will delete this entire file, since Eventhub is not used anymore by the proxy

azureholic commented 9 months ago

updated project, deleted file

if you want to use eventhub for chargeback data, create a continues export of loganalytics to eventhub.

https://learn.microsoft.com/en-us/azure/azure-monitor/logs/logs-data-export?tabs=portal#event-hubs

azureholic commented 9 months ago

done

iMicknl commented 9 months ago

Should I wait with my review, or is it fine to review now+tomorrow and create issues of what I notice?

azureholic commented 9 months ago

Just report what you find. This way we can build a backlog and prioritize