compilation fails due to undefined identifiers, neither google nor github can find me a second occurrence of these

[Mis012]

the following errors get printed when attempting compilation:

[ 38% 3545/9233] //art/runtime:libart clang++ runtime.cc
FAILED: out/soong/.intermediates/art/runtime/libart/android_arm_armv7-a-neon_core_shared/obj/art/runtime/runtime.o
PWD=/proc/self/cwd prebuilts/clang/host/linux-x86/clang-r353983c/bin/clang++ -c -Iart/runtime -Ibionic/libc/private -Iexternal/vixl/src -Iart/sigchainlib -Iexternal/zlib -Iart/runtime -mthumb -Os -fomit-frame-pointer -DANDROID -fmessage-length=0 -W -Wall -Wno-unused -Winit-self -Wpointer-arith -no-canonical-prefixes -DNDEBUG -UDEBUG -fno-exceptions -Wno-multichar -O2 -g -fno-strict-aliasing -fdebug-prefix-map=/proc/self/cwd= -D__compiler_offsetof=__builtin_offsetof -faddrsig -Wimplicit-fallthrough -Werror=int-conversion -Wno-reserved-id-macro -Wno-format-pedantic -Wno-unused-command-line-argument -fcolor-diagnostics -Wno-zero-as-null-pointer-constant -Wno-sign-compare -Wno-defaulted-function-deleted -Wno-inconsistent-missing-override -ffunction-sections -fdata-sections -fno-short-enums -funwind-tables -fstack-protector-strong -Wa,--noexecstack -D_FORTIFY_SOURCE=2 -Wstrict-aliasing=2 -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point -Werror=date-time -Werror=format-security -nostdlibinc -msoft-float -march=armv7-a -mfloat-abi=softfp -mfpu=neon  -Iart/cmdline -Iart/tools/cpp-define-generator -Iexternal/icu/icu4c/source/common -Iexternal/icu/android_icu4c/include -Ilibnativehelper/header_only_include -Ilibnativehelper/platform_include -Iexternal/zlib -Iart/libelffile -Iart/libartpalette/include -Isystem/core/libnativebridge/include -D__LIBNATIVEBRIDGE_API__=1 -Isystem/core/libnativeloader/include -D__LIBNATIVELOADER_API__=1 -Isystem/core/libbacktrace/include -Isystem/core/demangle/include -Isystem/core/liblog/include -Isystem/core/base/include -Iart/libartbase -Iexternal/lz4/lib -Iexternal/lzma/C -Iart/libdexfile -Iart/libprofile -Ibionic/libc/async_safe/include -Iexternal/libcxx/include -Iexternal/libcxxabi/include -Ibionic/libc/include -D__LIBC_API__=10000 -D__LIBM_API__=10000 -D__LIBDL_API__=10000 -Iout/soong/.intermediates/art/runtime/art_operator_srcs/gen -Iout/soong/.intermediates/art/tools/cpp-define-generator/cpp-define-generator-asm-support/android_arm_armv7-a-neon_core/gen -Isystem/core/include -Isystem/media/audio/include -Ihardware/libhardware/include -Ihardware/libhardware_legacy/include -Ihardware/ril/include -Iframeworks/native/include -Iframeworks/native/opengl/include -Iframeworks/av/include -isystem bionic/libc/include -isystem bionic/libc/kernel/uapi -isystem bionic/libc/kernel/uapi/asm-arm -isystem bionic/libc/kernel/android/scsi -isystem bionic/libc/kernel/android/uapi -Ilibnativehelper/include_jni -fno-rtti -ggdb3 -Wall -Werror -Wextra -Wstrict-aliasing -fstrict-aliasing -Wunreachable-code -Wredundant-decls -Wshadow -Wunused -fvisibility=protected -Wthread-safety -Wthread-safety-negative -Wimplicit-fallthrough -Wfloat-equal -Wint-to-void-pointer-cast -Wused-but-marked-unused -Wdeprecated -Wunreachable-code-break -Wunreachable-code-return -Wno-invalid-offsetof -Winconsistent-missing-override -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -O3 -DART_DEFAULT_GC_TYPE_IS_CMS -DIMT_SIZE=43 -DART_USE_READ_BARRIER=1 -DART_READ_BARRIER_TYPE_IS_BAKER=1 -DART_USE_GENERATIONAL_CC=1 -DART_DEFAULT_COMPACT_DEX_LEVEL=fast -DART_STACK_OVERFLOW_GAP_arm=8192 -DART_STACK_OVERFLOW_GAP_arm64=8192 -DART_STACK_OVERFLOW_GAP_mips=16384 -DART_STACK_OVERFLOW_GAP_mips64=16384 -DART_STACK_OVERFLOW_GAP_x86=8192 -DART_STACK_OVERFLOW_GAP_x86_64=8192 -DUSE_D8_DESUGAR=1 -DBUILDING_LIBART=1 -Wmissing-noreturn -DART_MCR_TARGET -DART_MCR_LLVM -DMCR_LLVM_GEN_INVOKE_HIST_ON_CACHE_MISS -DART_MCR_COMPILE_OS_METHODS -ferror-limit=0 -DART_MCR -DART_MCR_ANDROID_10 -DTARGET_DEVICE=arm '-DTARGET_CPU_VARIANT=""' -g -ferror-limit=0 -DART_MCR_TARGET_RT -DART_MCR_RT -DART_MCR_INTERPRETER_TO_QUICK_BRIDGE -DCRDEBUG -DCRDEBUG1 -DCRDEBUG2 -DART_TARGET -DART_ENABLE_CODEGEN_arm -Wframe-larger-than=1736 -DART_FRAME_SIZE_LIMIT=1736 -DART_BASE_ADDRESS=0x70000000 -DART_TARGET_ANDROID -DART_BASE_ADDRESS_MIN_DELTA=-0x1000000 -DART_BASE_ADDRESS_MAX_DELTA=0x1000000 -DANDROID_LINK_SHARED_ICU4C -target armv7a-linux-androideabi -Bprebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/arm-linux-androideabi/bin -DANDROID_STRICT -fPIC -D_USING_LIBCXX -flto=thin -fsplit-lto-unit -std=gnu++17 -Wsign-promo -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -Wno-thread-safety-negative -Wno-gnu-include-next -fvisibility-inlines-hidden -fno-rtti  -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -Werror=address-of-temporary -Werror=return-type -Wno-tautological-constant-compare -Wno-tautological-type-limit-compare -Wno-tautological-unsigned-enum-zero-compare -Wno-tautological-unsigned-zero-compare -Wno-c++98-compat-extra-semi -Wno-return-std-move-in-c++11 -MD -MF out/soong/.intermediates/art/runtime/libart/android_arm_armv7-a-neon_core_shared/obj/art/runtime/runtime.o.d -o out/soong/.intermediates/art/runtime/libart/android_arm_armv7-a-neon_core_shared/obj/art/runtime/runtime.o art/runtime/runtime.cc
art/runtime/runtime.cc:2901:6: error: use of undeclared identifier 'IS_REPLAY_ANY'
  if(IS_REPLAY_ANY() || IS_LIVE_ANY() || IS_CAPTURE()) {
     ^
art/runtime/runtime.cc:2901:25: error: use of undeclared identifier 'IS_LIVE_ANY'
  if(IS_REPLAY_ANY() || IS_LIVE_ANY() || IS_CAPTURE()) {
                        ^
art/runtime/runtime.cc:2901:42: error: use of undeclared identifier 'IS_CAPTURE'
  if(IS_REPLAY_ANY() || IS_LIVE_ANY() || IS_CAPTURE()) {
                                         ^
art/runtime/runtime.cc:2902:12: error: use of undeclared identifier 'ERROR'
    LOGRD5(ERROR) << __func__ << ": jit disabled";
           ^
4 errors generated.
17:31:50 ninja failed with: exit status 1
make: *** [build/make/core/main.mk:21: run_soong_ui] Error 1

google search for "IS_REPLAY_ANY" finds nothing, a github search finds "IS_REPLAY_ANY" precisely once in the place in this project where clang complains about it

[paschalis-mpeis]

Hi @Mis012 ,

These are leftovers from another component that was baked into this project. So feel free to weed those out!

That component was responsible for capturing and replaying inputs (by storing things like main-mem pages, registers, and some partial support for file descriptors).

Cheers, Paschalis

[paschalis-mpeis]

Actually all blocks (and references to pre-processor definitions) of ART_MCR_TARGET (or ART_MCR) should go.