search

paschmann / rasa-ui

Rasa UI is a frontend for the Rasa Framework
MIT License
957 stars 329 forks source link

Use NLU threshold to show no match in conversations module #182

Closed huberrom closed 5 years ago

huberrom commented 5 years ago

Really sorry for #181, I was in an hurry and I missed something.

So as I said :

@paschmann @pradeepmvn This PR has the same commits as PR #179 + a new functionnality

New functionnality : set the NLU threshold of your policy (in the agent config) and the conversation module will set No match when the confidence is lower than the threshold !

+

Same for the previous PR (that i'll close), there is a lot of commit, i don't know why but only the few last have changes

pradeepmvn commented 5 years ago

@huberrom thanks for the Awesome PR. I will release current version on rasa-ui and then squash merge your commits into a new version. On the threshold, I don't see where you are using it? Will be part of Rasa Core Policy?

huberrom commented 5 years ago

We are using the threshold in the view messages_expressions, to compare with the confidence of the intent. If the confidence is lower than the threshold, then we set the intent to null so the conversation module say it's not a No match.

We have prepared a docker-compose + update of the read.me to easily use the conversation module, using logstash and rabbitMQ. I'll create a new PR once this one is merge :)

paschmann commented 5 years ago

Thanks for the contribution, going to close this request due to recent changes.