paseo-network / runtimes

Runtimes for Polkadot community testnet
GNU General Public License v3.0
24 stars 25 forks source link

fix: system parachain chain spec generator #149

Closed AlexD10S closed 1 month ago

AlexD10S commented 1 month ago

When running pop up parachain with the latest paseo release (v1.3.1) I was getting an issue generating the chain-spec. Comparing the old one generated (v1.2.6) with the new one I noticed the difference was with the id:

"name": "Asset Hub Paseo Local",
"id": "asset-hub-paseo-local"

vs

“name": "Paseo Asset Hub Local",
"id": "paseo-asset-hub-local",

Fixed to use asset-hub-paseo-local.

pecorino-bot commented 1 month ago

Tests have finished.

Build

Status: success

Relay Chain

Status: failure

System Parachains

Status: success

Integration Tests

Status: failure

❌ Some tests have failed. Please check the details above for more information.

View full run details

al3mart commented 1 month ago

The change was introduced to avoid matching with any of the included spec ids in the sdk ChainSpecLoader. So that the spec names would start with paseo and not match any other asset-hub* posible value. Every spec was adapted. You can see that all the spec ids here start with paseo - https://github.com/paseo-network/paseo-chain-specs

Let's revisit if that is not the case anymore and follow up accordingly here.