search

paseto-toolkit / jpaseto

A library for creating and parsing Paseto in Java
Apache License 2.0
67 stars 15 forks source link

Adds PASERK Type #84

Closed sdelamo closed 2 years ago

sdelamo commented 2 years ago

My TestNG is not the most idiomatic 😅

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (8a06e83) into paserk (27531fe) will increase coverage by 0.33%. The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             paserk      #84      +/-   ##
============================================
+ Coverage     85.04%   85.37%   +0.33%     
- Complexity      289      299      +10     
============================================
  Files            58       59       +1     
  Lines           856      889      +33     
  Branches         56       57       +1     
============================================
+ Hits            728      759      +31     
- Misses           98      100       +2     
  Partials         30       30
Impacted Files Coverage Δ
.../src/main/java/dev/paseto/jpaseto/paserk/Type.java 93.93% <93.93%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27531fe...8a06e83. Read the comment docs.

sdelamo commented 2 years ago

Great start for PASERK support!

I can create a feature branch and we can work on flushing out the feature there if it helps! Just let me know!

that make sense to me.

sdelamo commented 2 years ago

should we merge this into the new base branch paserk and continue new development in a different PR?

bdemers commented 2 years ago

Merged into paserk! thanks again @sdelamo!!