search

pashagolub / pgxmock

pgx mock driver for golang to test database interactions
Other
393 stars 49 forks source link

Add missing methods to PgxPoolIface #139

Closed tulioguaraldob closed 1 year ago

tulioguaraldob commented 1 year ago

Add missing methods from PgxPoolIface to current *pgxpool.Pool (v5)

Hey, hope everyone is doing fine! I just made some adjustments to match the missing methods when mocking pgxpool. I've already spoken to pasha, and he said to open the PR, but before I need permission to push to the new branch I've created... Thank you!

pashagolub commented 1 year ago

Sorry. I don't get it. What permissions do you need?

Just fork the repo, create a branch in your fork, then create a pull request.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

tulioguaraldob commented 1 year ago

Oh, I just have some problems yesterday from random git confis on my machine too hehe, sorry for the misunderstood, Pasha. Here is my PR for the changes I've spoken to, thank u!

https://github.com/pashagolub/pgxmock/pull/140