Support dired-sidebar - Githubissues

fishyfriend commented 4 years ago

This PR adds support for saving and restoring dired-sidebar windows, as well as side windows generally.

Changes:

Dired-sidebar uses side windows, so the save/load code now includes the window-side and window-slot window parameters to preserve side window status. Without this change, side windows would be restored as ordinary windows, which breaks some behavior.
The window restoration process for dired-sidebar windows actually replaces the restored window with a fresh window created by dired-sidebar. This is done in order to avoid duplicating the implementation details of dired-sidebar's window setup in the serialization/deserialization code.
Lexical binding in workgroups2.el was broken and has been fixed.

Testing:

Manually verified that dired-sidebar windows are saved and restored and that they keep their status as side windows.
Added an automated test for above.
Manually tested that a couple other modes' windows (dired, magit) are saved and restored
Successfully ran the automated test suite with make deps && make testgui (I had to comment out the Magit test and 310-frames, which are broken on master)
I have not tested with other packages that use side windows.

redguardtoo commented 4 years ago

Thanks

redguardtoo commented 4 years ago

@fishyfriend , I re-applied your patch. Could you fix the unit test?

fishyfriend commented 4 years ago

Hi @redguardtoo,

The 305-dired-sidebar unit test is already passing on master; I've double-checked locally. Are you seeing anything different?

Regarding the other unit tests, these were broken prior to my changes. 310-frames looks related to the wg-config pickling issue, and 300-special-modes failed due to missing Magit dependencies. Magit has a LOT of pieces now -- like 15 or 20 separate .el files. Maybe Cask.el or some other tool has a way to specify test-only dependencies so they don't have to be hardcoded in the makefile. I am afraid I will not be willing to spend more time to fix these tests (unless I broke something) as I'm not actually using workgroups2. This PR was just something I came up with while evaluating the package. (This package is very useful indeed! But for my own workflow I ended up not needing it.)

redguardtoo commented 4 years ago

No problem. I will fix the unit test.

pashinin / workgroups2

Support dired-sidebar #88