Closed adabadadudu closed 2 years ago
Hi Pooia, thanks for this PR.
I'm not sure this works, but it looks good.
But you should make the changes on the master
and send PR to the master
because this is a new feature.
pls send this to master, then we'll work on this more.
Thanks
Oh wait, base was changed without conflict. don't close this, its ok. I'll review and test it.
So, i reviewed the code, this is not working. i'll keep this PR opened, we can work on this feature on this PR.
I am sorry for this mistake ( I forget or forgot )
I don't know how do I
how I do?
oh . what I do ?
Nothing for now. we'll work on it later.
I'm involved in school exams for now and cannot work on the patches yet.
I'm gonna close this PR. I've got plan to work on this feature and I make a new PR later.
if you don't have plan for end keyword , I have a plan named Pull Request ( Why you say PR to pull request? )
also it is Pashmak 100th pull request
and I change master to 0.8