search

pasko-zh / brzo_i2c

Brzo I2C is a fast I2C Implementation written in Assembly for the esp8266
GNU General Public License v3.0
244 stars 47 forks source link

Question about "round" method #12

Closed piersfinlayson closed 7 years ago

piersfinlayson commented 7 years ago

Hi - nice library! Making use of it in my non-RTOS esp SDK application the linker is not able to find the round() function in any of the system libraries I'm already including. Where are you expecting to pick this up from? I'm already having problems with available RAM so I'm keen not to include any extra library functions unnecessarily!

valkuc commented 7 years ago

About round see my last comment here https://github.com/pasko-zh/brzo_i2c/pull/10

piersfinlayson commented 7 years ago

@valkuc - Yes, makes sense to me. I'll use your workaround for now.

pasko-zh commented 7 years ago

Of course @valkuc is absolutely right! No floating point operations are needed to perform the round as I wanted it to have. Don't know why I didn't catch that much earlier, I guess I am getting old :-/

I will change this in the next release.

valkuc commented 7 years ago

"Two heads are better than one" so, no problem ;-) I'm not young too :-)

pasko-zh commented 7 years ago

Added to 1.2.0