search

pasky / pachi

A fairly strong Go/Baduk/Weiqi playing program
http://pachi.or.cz/
GNU General Public License v2.0
514 stars 117 forks source link

Ladder #51

Closed lemonsqueeze closed 8 years ago

lemonsqueeze commented 8 years ago

Can read out countercaptures in ladders (overkill ?) and fixes some issues with suicides. New code matches many more ladders (around x4 iirc) so it can become a problem for life&death if they all get pruned in prior code. useful_ladder() tries to address that.

pasky commented 8 years ago

Depends on PR#50.

pasky commented 8 years ago

Will be happy to review after update.

lemonsqueeze commented 8 years ago

Should be good now.

lemonsqueeze commented 8 years ago

Yes and no, this is a bit confusing: atm ladder.t tests the middle ladder reader which has no issues with this but it still fails if middle ladders are disabled. Maybe there should be a border_ladder.t as well, this code path is not tested right now.

pasky commented 8 years ago

Hmm no problem then. Thanks a lot, again very happy with well tested code.