search

pasky / pachi

A fairly strong Go/Baduk/Weiqi playing program
http://pachi.or.cz/
GNU General Public License v2.0
506 stars 117 forks source link

Bug fix in json reporting for cans != 4 #87

Closed pnprog closed 5 years ago

pnprog commented 5 years ago

The json formatting was incorrect for cans values (defined at line 146) different than 4. I modified the values of cans to extract more data using goreviewpartner and found out about this bug.

lemonsqueeze commented 5 years ago

Hi,

I saw your post on lifein19x19, please discuss pull request details here instead, this thread isn't meant for development purposes:

I searched in the code, and modified the values for the number of variations, and deepness for each variations. But the resulting json formatting was incorrect (some comma missing between elements of arrays). I was able to modify the code to fix it, compiled it and tested it on my computer.

Next I sent a pull request on the project's Github, and got a tons of issues with that Travis CI build. I don't know much about C++, but I am fairly confident this is unrelated to the code changes I mage:

The command "if [ "$TRAVIS_OS_NAME" = linux ] && [ "$DCNN" = 1 ]; then sudo apt-get install libcaffe-cpu-dev -y ; fi" failed and exited with 100 during .

I don't know what to do next to have that pull request, accepted. Could you help me check?

Yeah, sometimes apt-get fails for some reason on the travis machine. Usually it's just a matter of triggering the build again, let me see ...

pnprog commented 5 years ago

I saw your post on lifein19x19, please discuss pull request details here instead, this thread isn't meant for development purposes

Sorry about that! It's just that I did not know what to do at the time.

I am looking at the code to see what other data could be "extracted" from Pachi, I maybe have other similar pull requests in the future.