Closed a-corni closed 1 year ago
Great! We can close the other PR now
About the if: They are needed, it is actually an issue that was not reported before (and it is independent of the dmm, I can solve it in another PR if your want). The issue is basically that the wrong error message is displayed, see below with a raman channel declared twice, what is actually failing is the matching of raman_1
, not raman
.
@HGSilveri I think we are done with this PR, it does everything we wanted and beyond.
The last three commits take into account last review from #568:
config_slm_mask
.