pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
171 stars 60 forks source link

Handle parametrized sequence, switching device and DMM, and serialize config_det_map as an operation #576

Closed a-corni closed 1 year ago

a-corni commented 1 year ago

The last three commits take into account last review from #568:

HGSilveri commented 1 year ago

Great! We can close the other PR now

a-corni commented 1 year ago

About the if: They are needed, it is actually an issue that was not reported before (and it is independent of the dmm, I can solve it in another PR if your want). The issue is basically that the wrong error message is displayed, see below with a raman channel declared twice, what is actually failing is the matching of raman_1, not raman. image

a-corni commented 1 year ago

@HGSilveri I think we are done with this PR, it does everything we wanted and beyond.