pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
171 stars 60 forks source link

Pin matplotlib < 3.8 #582

Closed HGSilveri closed 1 year ago

HGSilveri commented 1 year ago

It seems that matplotlib 3.8 does two disruptive things to our CI workflow:

  1. It introduces type-hints
  2. It drops support for python 3.8

I briefly looked into the changes that it will take to make our current code pass the mypy checks and I think some warrant usingtype:ignore . However, these type:ignores will then be seen as "unused" when using matplotlib < 3.8, which is a necessity if python == 3.8.

Also, I would prefer that all python versions have access to the same matplotlib version, so for now I'll just restrict matplotlib to be < 3.8. I don't expect us to miss out on any functionality, but we can always revaluate. Once we drop support for python 3.8, we can maybe lift this restriction too.