search

pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
159 stars 57 forks source link

Release v15.3 #611

Closed a-corni closed 7 months ago

a-corni commented 7 months ago

Making a hot fix to enable the use of parametrized phase in eom mode.

madagra commented 7 months ago

@a-corni you should likely use MyPy v1.6.1 in order to make the tests pass.

a-corni commented 7 months ago

@a-corni you should likely use MyPy v1.6.1 in order to make the tests pass.

MyPy version is kept at 1.2... I will keep investigating 🔍

a-corni commented 7 months ago

The error seems to be coming from the module referencing. They made a new release on Nov. 14th and the error shown (see below) points directly to it according to this issue on mypy

/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/referencing/jsonschema.py:499: error: Invalid "type: ignore" comment [syntax]

I have followed what the mypy developpers suggested there: Add to mypy.ini:

[mypy-discord.*] follow_imports = skip

But this does not seem to have changed anything - which is weird, it should have deleted the error messages coming from referencing...

a-corni commented 7 months ago

The error seems to be coming from the module referencing. They made a new release on Nov. 14th and the error shown (see below) points directly to it according to this issue on mypy

/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/referencing/jsonschema.py:499: error: Invalid "type: ignore" comment [syntax]

I have followed what the mypy developpers suggested there: Add to mypy.ini:

[mypy-discord.*] follow_imports = skip

But this does not seem to have changed anything - which is weird, it should have deleted the error messages coming from referencing...

Solved by using skip instead of silent (it makes a difference in the end)