search

pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
159 stars 57 forks source link

JSON serialization support for numpy integer types #617

Closed HGSilveri closed 7 months ago

HGSilveri commented 7 months ago
HGSilveri commented 7 months ago

Looks good to me ! Just out ouf curiosity, why were the changes in pre-commit-config.yaml and the exclusion of venv necessary ?

They are unrelated, it's just because I started working in a new setup where I'm setting a local __venv__ folder to store my virtual environment. The pre-commit probably needed updating for a while but it only became apparent once I tried to install it from scratch. I guess that these changes would ideally be in a separate PR but I was lazy...

a-corni commented 7 months ago

Looks good to me ! Just out ouf curiosity, why were the changes in pre-commit-config.yaml and the exclusion of venv necessary ?

They are unrelated, it's just because I started working in a new setup where I'm setting a local __venv__ folder to store my virtual environment. The pre-commit probably needed updating for a while but it only became apparent once I tried to install it from scratch. I guess that these changes would ideally be in a separate PR but I was lazy...

Thanks, I understood these changes are unrelated to the topic, but I was trying to understand what was their purpose :)