search

pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
159 stars 57 forks source link

Support version v4.17.3 Jsonschema #625

Closed a-corni closed 6 months ago

a-corni commented 6 months ago

Using PR #572, restoring jsonschema v4.17.3 I am first checking that a pipeline works with jsonschema=4.17.3, will move it to jsonschema>4.18.0 afterwards Closes #624

a-corni commented 6 months ago

Moving condition in requirements.txt to jsonschema >= 4.17.3 since it is working for jsonschema == 4.17.3

a-corni commented 6 months ago

LGTM but we should probably do an hotfix instead, otherwise the guys will be blocked until we release v0.17. Wdyt?

That's True, I also have someone asking for #616 to be released in a hotfix, should we first merge this PR and make a hotfix with #616 containing them both ?

Edit: I guess we can merge this PR into master first

HGSilveri commented 6 months ago

That's True, I also have someone asking for #616 to be released in a hotfix, should we first merge this PR and make a hotfix with #616 containing them both ?

Edit: I guess we can merge this PR into master first

I would make a new hotfix/v0.16.1 branch, merge both PRs into it and then merge that to master. Every merge to master expects a bump in the version, so merging separately would normally require two version bumps.