search

pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
159 stars 57 forks source link

Explicitly define public symbols for all modules #630

Closed HGSilveri closed 5 months ago

HGSilveri commented 5 months ago

@lvignoli I'm not going to add pyright to our CI, please let me know if this works for you.

Fixes #551 .

V2: Also exposing all classes a regular user might require at the top-level.

Closes #552 .

lvignoli commented 5 months ago

This works, thanks! But only for the 5 top-level symbols that are Sequence, Register, etc. To properly close #551, it needs to fix imports for the whole pulser package.

HGSilveri commented 5 months ago

Thanks for the review @a-corni ! @lvignoli : Any remarks?

lvignoli commented 5 months ago

Oh god it's happening 🥁

lvignoli commented 5 months ago

@HGSilveri I trust you to decide what's best to expose, I do not have anything to add 😀