pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
159 stars 57 forks source link

Enabling definition of multiple noise channels and noise channels in XY #647

Closed a-corni closed 4 months ago

a-corni commented 4 months ago
review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

HGSilveri commented 4 months ago

This is starting to mix a fix and a feature :sweat_smile:

a-corni commented 4 months ago

This is starting to mix a fix and a feature 😅

I am stopping here ;) In a way it's a fix since everything was already there 😇 But yes I could make a separate PR with only the fix (SPAM in XY), and later merge this one with the rest that is more development, and merge it into develop

a-corni commented 4 months ago

@HGSilveri should I still handle kraus_ops.html (but redirecting it to the same notebook as effective_noise.html) ?

HGSilveri commented 4 months ago

@HGSilveri should I still handle kraus_ops.html (but redirecting it to the same notebook as effective_noise.html) ?

Isn't that done here already?

a-corni commented 4 months ago

@HGSilveri should I still handle kraus_ops.html (but redirecting it to the same notebook as effective_noise.html) ?

Isn't that done here already?

No I have only changed the name of the file 🙄 I will implement this then

HGSilveri commented 4 months ago

@HGSilveri should I still handle kraus_ops.html (but redirecting it to the same notebook as effective_noise.html) ?

Isn't that done here already?

No I have only changed the name of the file 🙄 I will implement this then

Then I think I don't get what you are referring to because I already see all the changes I thought were required

a-corni commented 4 months ago

@HGSilveri should I still handle kraus_ops.html (but redirecting it to the same notebook as effective_noise.html) ?

Isn't that done here already?

No I have only changed the name of the file 🙄 I will implement this then

Then I think I don't get what you are referring to because I already see all the changes I thought were required

Now I understand the confusion 😅 All done then