pasqal-io / Pulser

Library for pulse-level/analog control of neutral atom devices. Emulator with QuTiP.
Apache License 2.0
181 stars 65 forks source link

Apply amplitude fluctutations at a fixed rate #712

Open HGSilveri opened 4 months ago

HGSilveri commented 4 months ago

Now that I see it, the implementation is perhaps a bit weird, since in the case of a Sequence containing only one super-long pulse, the value of noise_base that will be applied will be the same all along - there will be no "fluctuation" actually. I would suggest to define a rate at which fluctuations should happen (and perhaps they should fluctuate at each ns ?), and sample them at each run (as it's done at the moment).

_Originally posted by @a-corni in https://github.com/pasqal-io/Pulser/pull/710#discussion_r1684308905_

HGSilveri commented 1 week ago

It seems that the dominant fluctuations in amplitude actually occur from shot to shot. As such, I propose we restrict the existent "amplitude fluctuation" to be a constant shift in the amplitude of a global channel over the entire sequence. If at some point we want to also introduce "intra-shot" fluctuations, we would require additional parameters for that.