passaH2O / dorado

For shallow-water Lagrangian particle routing.
https://passah2o.github.io/dorado
MIT License
54 stars 9 forks source link

Travel Path Routines #17

Closed wrightky closed 4 years ago

wrightky commented 4 years ago

Introduces two main updates:

Lastly, updated the examples and associated docs for the travel path routine. Also fixed a bug I ran into in get_state() if some particles don't iterate very far if originally routed by time.

We can wait to merge this until after the review process, although most of these things are periphery changes, so it might not matter. Up to you

elbeejay commented 4 years ago

Before we merge, I think you should update the version number in __init__.py to either "2.1.0" or "2.0.1" because merging this PR will create a difference between the pip version and the repository version of the code. I think this is in-line with PEP-440, which outlines Python software versioning "three components ('major.minor.micro')". I don't know whether we should consider this "minor" or "micro" in scope, but it should definitely change the version number so that we can do another "release" on GitHub which updates the pip version.

Besides that, I think we're good to merge.

wrightky commented 4 years ago

Good point on the version number, I'll make sure to keep proper versioning in mind for future updates. Looked into it and it seems like this classifies as 'minor', so I've updated to 2.1.0.