Fix and update build actions

passaH2O / dorado

For shallow-water Lagrangian particle routing.

https://passah2o.github.io/dorado

MIT License

54 stars 9 forks source link

Fix and update build actions #44

Closed wrightky closed 1 year ago

wrightky commented 1 year ago

Should fix the assertion error for the three tests that were giving us trouble. Passed locally on Windows, still need to see if it passes the Ubuntu tests during auto-build. Closes #41

codecov[bot] commented 1 year ago

Codecov Report

Merging #44 (2fe1a4c) into master (e485471) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           master      #44    +/-   ##
========================================
  Coverage   97.66%   97.66%            
========================================
  Files           2        4     +2     
  Lines         557     1114   +557     
========================================
+ Hits          544     1088   +544     
- Misses         13       26    +13

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wrightky commented 1 year ago

Looks like (as of literally yesterday!) legacy Python 2.7 versions are no longer supported in GitHub actions. Will drop v2.7 from the build.

In other news, the Ubuntu checks passed.

elbeejay commented 1 year ago

This looks good to me :+1:

wrightky commented 1 year ago

This PR is now a couple related updates to the build action:

Tests have been fixed by using pytest.approx in for the tests that started returning an AssertionError
Drops legacy Python 2.7 testing from build.yml, which is no longer supported by GitHub actions
Adds Python 3.10 and 3.11 (both of which are passing, which is nice)
Since Python 3.7 is nearing end of life in a couple weeks, updates the examples to be tested on 3.9 as the default

Let me know if this is worth incrementing the version number. Might be worth adding a new release to PyPI if only to update the version badge on the home page.

elbeejay commented 1 year ago

This PR is now a couple related updates to the build action:

Tests have been fixed by using pytest.approx in for the tests that started returning an AssertionError

Drops legacy Python 2.7 testing from build.yml, which is no longer supported by GitHub actions

Adds Python 3.10 and 3.11 (both of which are passing, which is nice)

Since Python 3.7 is nearing end of life in a couple weeks, updates the examples to be tested on 3.9 as the default

Let me know if this is worth incrementing the version number. Might be worth adding a new release to PyPI if only to update the version badge on the home page.

Dropping 2.7 from support is a milestone, I'd support a minor incrementation of the version number - it isn't really a breaking change so I don't think we need to move a full version up.