passaH2O / pygeoflood

Compound flood mapping program based on high-resolution terrain analyses
https://passah2o.github.io/pygeoflood/
GNU General Public License v3.0
7 stars 0 forks source link

Refactoring for custom inputs #10

Closed mdp0023 closed 1 month ago

mdp0023 commented 1 month ago

For each method, whichever previous files it relied on are now user defined parameters. If parameter is None, it uses the default path to that file. All file paths are set when the class is initialized.

Each method still checks if the user defined or default input exists and returns a value error if it cannot find one.

Other major change is how file names are created. Since all default file names are initialized with the class, the tool get_file_path() is a bit redundant, and file paths can just be set within the pygeoflood class.

markwang0 commented 1 month ago

looks great! I made two small changes:

markwang0 commented 1 month ago

sorry, just realized we can't initialize dem_path=None, because we need that to set all file paths when instantiating the class. changed it back in d668216