src.csv table not populating COMID numbers for all stream segments

passaH2O / pygeoflood

Compound flood mapping program based on high-resolution terrain analyses

https://passah2o.github.io/pygeoflood/

GNU General Public License v3.0

7 stars 0 forks source link

src.csv table not populating COMID numbers for all stream segments #13

Open mdp0023 opened 3 weeks ago

mdp0023 commented 3 weeks ago

Running a catchment in Austin (happens a few times in a few different catchments) where the src table doesn't populate the COMID value for some of the channel segments. Looks like it is a smaller channel segment (less than 100 meters in length). Causing inundation function to crash. Attached are some of the relevant files showing missing COMID value.

dem_5781307_201310310900_floodstage.csv dem_5781307_river_attributes.csv dem_5781307_src.csv

mdp0023 commented 2 weeks ago

Two potential patches in tools.py:

in get_flood_stage, skip over when comid is nan. Does not map inundation for this reach segement. Potential error in missing inundation extent
in get_river_attributes, add additional sjoin based on nearest catchment. Fills gaps, allows for inundation to be mapped for missing reach segements. Potential error based on HAND, where inundation depth is exceedingly high. Might be related to d8 flow direction in HAND calculation

testing patches in src_patch branch