passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
41 stars 27 forks source link

Fix deployment with sentinelProxy.enabled=false #17

Closed olivierboudet closed 1 year ago

olivierboudet commented 1 year ago

Passbolt can not be deployed with sentinelProxy.enabled=false (try to mount a secret which does not exist)

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

dlen commented 1 year ago

Hi! @olivierboudet

Thanks for your contribution! While your PR looks good to me (we are actually missing the .Values.app.cache.redis.sentinelProxy.enabled in more parts of the deployment). We are unable to reproduce your issue, could you show some logs of what is currently happening to you as well as the values.yaml you are using (removing the sensitive parts of course)

olivierboudet commented 1 year ago

Hi @dlen , You can try with this value file :

cat values.yaml 
redisDependencyEnabled: false

mariadbDependencyEnabled: true

mariadb:
  architecture: standalone

app:
  cache:
    redis:
      enabled: false
      sentinelProxy:
        enabled: false

cronJobEmail:
  enabled: true
  schedule: "* * * * *"

When generating templates, we can see that a reference to secretName but no creation :

$ helm template passbolt passbolt/passbolt -f values.yaml | grep -i "name: passbolt-sec-redis-proxy"         
            secretName: passbolt-sec-redis-proxy
                secretName: passbolt-sec-redis-proxy

So when running helm install passbolt passbolt/passbolt -f values.yaml pods does not start with this error :

  Warning  FailedMount  7s (x7 over 38s)  kubelet            MountVolume.SetUp failed for volume "passbolt-depl-srv-sec-redis-proxy" : secret "passbolt-sec-redis-proxy" not found
dlen commented 1 year ago

Thanks a lot for your contribution!