passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
41 stars 27 forks source link

Missing value used in deployment.yaml #29

Closed xskrasek closed 1 year ago

xskrasek commented 1 year ago

Hello,

There is this value on line 137 in deployment yaml.

{{- toYaml .Values.redisProxyResources | nindent 12 }}

The value is not defined in the values.yaml file. Is this intentional?

dlen commented 1 year ago

Hey thanks for the heads up! This is totally not intentional.

Maybe we could use this to move the resources entry to some other entry. Not sure what would be more ergonomic:

.Values.app.cache.redis.sentinelProxy.resources Or .Values.app.resources.redisProxy