search

passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
40 stars 27 forks source link

Use cpu arch in kubectl download url #44

Closed debugger24 closed 9 months ago

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

debugger24 commented 11 months ago

Is there any automated way to update Values section README.md table ?

dlen commented 11 months ago

Thanks for your contribution @debugger24 !

We usually use helm-docs to auto-generate the readme table based on the comments of the values.yaml

djtecha commented 9 months ago

I believe this will fail on most pi's btw too since the uname -m returns aarch64. I'm happy I ran into this issue though as the job kept crashing until I hardcoded it like so:


    KUBECTL_DOWNLOAD_CMD: "curl -LO \"https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/arm64/kubectl\""
dlen commented 9 months ago

Hello!

Thanks for the contribution! However, in the current state, we won't be merging it as we believe that it is enough with the KUBECTL_DOWNLOAD_CMD from values.yaml.