passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
40 stars 27 forks source link

cronjob "cron-proc-email" and few other resources doesn't take imageRegistry global parameter #56

Closed SmartGuyy closed 8 months ago

SmartGuyy commented 8 months ago

Hello,

I noticed few issues with this chart :

This is the values file i end up with so i can have "imageRegistry" correctly defined everywhere (except for cron-proc-email, where i couldn't find a solution --> i need to define manually after each deployment...) :

global:
  imagePullSecrets: 
    - xxx
  imageRegistry: ${CI_REGISTRY}
app:
  initImage:
    repository: ${MARIADB_IMAGE_REPO}
    tag: ${MARIADB_IMAGE_TAG}
    registry: ${CI_REGISTRY}
  image:
    repository: ${PASSBOLT_IMAGE_REPO}
    tag: ${PASSBOLT_IMAGE_TAG}
  cache:
    redis:
      enabled: true
      sentinelProxy:
        enabled: true
        image:
          repository: ${HAPROXY_IMAGE_REPO}
          tag: ${HAPROXY_IMAGE_TAG}
mariadb:
  image:
    repository: ${MARIADB_IMAGE_REPO}
    tag: ${MARIADB_IMAGE_TAG}
redis:
  auth:
  sentinel:
    enabled: true
    image:
      repository: ${REDIS_IMAGE_REPO}
      tag: ${REDIS_IMAGE_TAG}
      registry: ${CI_REGISTRY}
  image:
    repository: ${REDIS_IMAGE_REPO}
    tag: ${REDIS_IMAGE_TAG}
    registry: ${CI_REGISTRY}
dlen commented 8 months ago

Thanks for the heads up! We'll patch this one in the next release

dlen commented 8 months ago

Fixed in 0.5.0